Skip to content

Fix TestAlertmanagerSharding integration test. #4083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2021
Merged

Fix TestAlertmanagerSharding integration test. #4083

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 16 additions & 11 deletions integration/alertmanager_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,8 +233,6 @@ func TestAlertmanagerClustering(t *testing.T) {
}

func TestAlertmanagerSharding(t *testing.T) {
t.Skip("Flaky test under investigation")

tests := map[string]struct {
legacyAlertStore bool
}{
Expand Down Expand Up @@ -305,7 +303,7 @@ func TestAlertmanagerSharding(t *testing.T) {
// We know that the ring has settled when every instance has some tenants and the total number of tokens have been assigned.
// The total number of tenants across all instances is: total alertmanager configs * replication factor.
// In this case: 30 * 2
require.NoError(t, alertmanagers.WaitSumMetrics(e2e.Equals(60), "cortex_alertmanager_tenants_owned"))
require.NoError(t, alertmanagers.WaitSumMetricsWithOptions(e2e.Equals(60), []string{"cortex_alertmanager_config_last_reload_successful"}, e2e.SkipMissingMetrics))
require.NoError(t, alertmanagers.WaitSumMetrics(e2e.Equals(float64(1152)), "cortex_ring_tokens_total"))

// Now, let's make sure state is replicated across instances.
Expand All @@ -322,21 +320,28 @@ func TestAlertmanagerSharding(t *testing.T) {
EndsAt: time.Now().Add(time.Hour),
}

// 2b. For each tenant, with a replication factor of 2 and 3 instances there's a chance the user might not be in the first selected replica.
// 2b. For each tenant, with a replication factor of 2 and 3 instances there's a chance the user might not be in one of the replicas.
// Therefore, try to create a silence on every instance and expect two silences to exist.
c1, err := e2ecortex.NewClient("", "", alertmanager1.HTTPEndpoint(), "", userID)
require.NoError(t, err)
c2, err := e2ecortex.NewClient("", "", alertmanager2.HTTPEndpoint(), "", userID)
require.NoError(t, err)
c3, err := e2ecortex.NewClient("", "", alertmanager3.HTTPEndpoint(), "", userID)
require.NoError(t, err)

err = c1.CreateSilence(context.Background(), silence)
if err != nil {
err := c2.CreateSilence(context.Background(), silence)
require.NoError(t, err)
} else {
require.NoError(t, err)
errs := []error{}
if err := c1.CreateSilence(context.Background(), silence); err != nil {
errs = append(errs, err)
}
if err := c2.CreateSilence(context.Background(), silence); err != nil {
errs = append(errs, err)
}
if err := c3.CreateSilence(context.Background(), silence); err != nil {
errs = append(errs, err)
}
assert.Equal(t, 1, len(errs), "expected exactly one client to error, got:\n %v", errs)

assert.NoError(t, alertmanagers.WaitSumMetricsWithOptions(e2e.Equals(float64(2)), []string{"cortex_alertmanager_silences"}), e2e.WaitMissingMetrics)
assert.NoError(t, alertmanagers.WaitSumMetricsWithOptions(e2e.Equals(float64(4)), []string{"cortex_alertmanager_silences"}), e2e.WaitMissingMetrics)
})
}
}