Skip to content

Fix ruler API #3917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 5, 2021
Merged

Fix ruler API #3917

merged 1 commit into from
Mar 5, 2021

Conversation

pracucci
Copy link
Contributor

@pracucci pracucci commented Mar 5, 2021 •
edited
Loading

What this PR does:
The grpc upgrade in #3884 has broken the ruler rules API endpoint:

msg="GET /api/prom/api/v1/rules (500) 4.012183ms Response: \"{\\\"status\\\":\\\"error\\\",\\\"data\\\":null,\\\"errorType\\\":\\\"server_error\\\",\\\"error\\\":\\\"unable to retrieve rules from other rulers, rpc error: code = Internal desc = grpc: error while marshaling: proto: Marshal called with nil\\\"}\"

This PR fixes it. An integration test will be added once #3916 gets merged, but this PR has been manually tested.

Which issue(s) this PR fixes:
N/A

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@pracucci
Fix ruler API
77fdffc 
Signed-off-by: Marco Pracucci <[email protected]>
@pracucci pracucci requested a review from gouthamve March 5, 2021 17:15
@pracucci pracucci mentioned this pull request Mar 5, 2021
Merged
3 tasks
@gouthamve gouthamve merged commit d6d0669 into cortexproject:master Mar 5, 2021
@pracucci pracucci deleted the fix-ruler branch March 8, 2021 08:02
gouthamve pushed a commit to grafana/cortex that referenced this pull request Mar 9, 2021
@pracucci @gouthamve
Fix ruler API (cortexproject#3917)
75a9300 
Signed-off-by: Marco Pracucci <[email protected]>
roystchiang pushed a commit to roystchiang/cortex that referenced this pull request Apr 6, 2022
@pracucci @harry671003
Fix ruler API (cortexproject#3917)
0336a92 
Signed-off-by: Marco Pracucci <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@gotjosh gotjosh gotjosh approved these changes

@pstibrany pstibrany pstibrany approved these changes

@gouthamve gouthamve gouthamve approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pracucci @gotjosh @pstibrany @gouthamve