WIP: Only idle compact samples from the head of a configurable age. #3845
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change limits the effect of idle compaction to only create blocks from the of samples which have reached a configurable age. This change is make the way for allowing ingestion of samples concurrently with compaction (separate commit). Signed-off-by: Steve Simpson <[email protected]>
Signed-off-by: Steve Simpson <[email protected]>
|
Should we close it for now, given we've tried to mitigate it with a jitter in #3850 ? |
|
Yeah makes sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This change limits the effect of idle compaction to only create blocks
from the of samples which have reached a configurable age. This change
is make the way for allowing ingestion of samples concurrently with
compaction.
I'm putting this commit up as a draft for discussion - a second commit is
needed to actually enable the pushing. This commit only limits the
compaction range.
Which issue(s) this PR fixes:
Fixes #3832
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]