Memberlist status page #3575
Merged
Memberlist status page #3575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtlisi
approved these changes
Dec 9, 2020
CHANGELOG.md
Outdated
There was a problem hiding this comment.
nit(optional): It may be good to clarify the mechanism used to view/download.
Suggested change
| * [ENHANCEMENT] Memberlist: add status page with available details about memberlist-based KV store and memberlist cluster. It's also possible to view KV values in Go struct or JSON format, or download for inspection. #3575 | |
| * [ENHANCEMENT] Memberlist: add status page with available details about memberlist-based KV store and memberlist cluster. Additional query parameters can be added to view KV values in either Go struct or JSON format, or to download KV values for inspection. #3575 |
There was a problem hiding this comment.
I think people will mostly just click on the links in the page (see screenshot). I'm not sure this is worth having in changelog.
ranton256
approved these changes
Dec 9, 2020
pracucci
approved these changes
Dec 10, 2020
Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does: This PR adds memberlist status page to Cortex. Status page shows memberlist cluster members, and some details about KV store that members are gossiping about. There is also possibility to inspect values in JSON or Go struct format, or download for offline inspection.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]