Split ReadRing.GetAll() into two functions #3460
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marco Pracucci <[email protected]>
pstibrany
approved these changes
Nov 4, 2020
Signed-off-by: Marco Pracucci <[email protected]>
Signed-off-by: Marco Pracucci <[email protected]>
|
@pstibrany Thanks for your review! I addressed your comments and should be ready for a second pass review 🙏 |
pstibrany
reviewed
Nov 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
In the PR #3414 we're working to add zone-awareness support to
Ring.GetAll(). The new logic (which triggers when zone-awareness replication is enabled) is not safe to apply in all contexts whereGetAll()is used.The reason is that
GetAll()is currently used for two very distinct purposes:The zone-awareness logic should apply to (2) but not to (1).
In this PR, I'm proposing to split
GetAll()intoGetAllHealthy()(to cover case 1) andGetReplicationSetForOperation()(to cover case 2). The reason why I renamedGetAll()intoGetReplicationSetForOperation()is so that we can signal downstream projects about this change and let them take an informed decision whether should be used one or the other one.Which issue(s) this PR fixes:
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]