Properly calculate image tag in GitHub Actions #3423
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like the test.1 docker image was properly uploaded, yay! https://quay.io/repository/cortexproject/cortex?tab=tags |
Signed-off-by: Chris Marchbanks <[email protected]>
csmarchbanks
force-pushed
the
ci-for-release-1.5
branch
from
c535d2e to
9d53888
Compare
pracucci
approved these changes
Oct 29, 2020
There was a problem hiding this comment.
Good job @csmarchbanks and sorry for all the struggles. I didn't consider it would have been the 1st release with GitHub actions. The changes make sense to me.
gouthamve
approved these changes
Oct 29, 2020
pracucci
pushed a commit
that referenced
this pull request
Nov 10, 2020
* Cut release 1.5.0-rc.0 (#3417) Signed-off-by: Chris Marchbanks <[email protected]> * Deploy on master or tags (#3419) Signed-off-by: Chris Marchbanks <[email protected]> * Properly calculate image tag in GitHub Actions (#3423) Signed-off-by: Chris Marchbanks <[email protected]> * fix: register querier routes explicitly with handler for instrumentation (#3436) * fix: register querier routes explicitly with handler for instrumentation Signed-off-by: Jacob Lisi <[email protected]> * fix: use legacy prefix for querier routes Signed-off-by: Jacob Lisi <[email protected]> * remove unneeded changelog entry Signed-off-by: Jacob Lisi <[email protected]> * ensure the internal querier router uses the Server prefix Signed-off-by: Jacob Lisi <[email protected]> * simplify prefixes Signed-off-by: Jacob Lisi <[email protected]> * fix import issue caused by IDE Signed-off-by: Jacob Lisi <[email protected]> * chore: ensure internalQuerier utilizes identical authMiddleware to API (#3439) Signed-off-by: Jacob Lisi <[email protected]> * Cut release 1.5.0-rc.1 Signed-off-by: Chris Marchbanks <[email protected]> * Cut release 1.5.0 (#3473) * Cut release 1.5.0 * Update versions in k8s/ and docs/ Signed-off-by: Chris Marchbanks <[email protected]> Co-authored-by: Jacob Lisi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a new makefile command for getting the image-tag that will accurately calculate the tag in GitHub actions or locally.
Make sure that this actions run properly deploys v1.5.0-test.1: https://github.com/cortexproject/cortex/actions/runs/336168200