Export distributor method to get ingester replication set #3356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
replay
changed the title
Signed-off-by: Mauro Stettler <[email protected]>
replay
force-pushed
the
export_distributor_method
branch
from
4b8c15b to
387979a
Compare
pracucci
approved these changes
Oct 15, 2020
Signed-off-by: Mauro Stettler <[email protected]>
gotjosh
approved these changes
Oct 15, 2020
|
Is it possible that this unit test which failed is unstable? I can't see how this change would cause that issue, but I don't have permissions to restart it. |
gouthamve
approved these changes
Oct 15, 2020
gotjosh
added a commit
to gotjosh/cortex
that referenced
this pull request
Oct 20, 2020
…rgid-ctx * 'master' of github.com:cortexproject/cortex: Enforce integration tests default flags config to never be overwritten (cortexproject#3370) Avoid deletion of blocks which are not shipped (cortexproject#3346) Upgrade Thanos to latest master (cortexproject#3363) Migrate CircleCI workflows to GitHub Actions (2/3) (cortexproject#3341) Remove comments that doesn't seem right (cortexproject#3361) add ingester interface (cortexproject#3352) Fail fast an ingester if unable to load existing TSDBs (cortexproject#3354) Fixed Gossip memberlist members joining when addresses are configured using DNS-based service discovery (cortexproject#3360) Export distributor method to get ingester replication set (cortexproject#3356) Correct link for Block Storage reference (cortexproject#3234) Added section on Cleaner. (cortexproject#3327) Update prometheus vendor to master (cortexproject#3345) adding GHA CI env variable check (cortexproject#3351) Add ingesters shuffle sharding support on the read path (cortexproject#3252)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to query all Ingesters of a replication set for some data, to do this I can use the distributor method
ForReplicationSet(). But to obtain the replication set which I need to query I'd need to be able to call the distributor methodgetIngestersForMetadata(), which is currently not exported. Would it be fine for you to export that method, or is there a better way for me to obtain the replication set that I need to query?