Skip to content

Set cortex as user agent for requests #3264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 2, 2020
Merged

Set cortex as user agent for requests #3264

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d66130a
Set cortex as user agent for requests
Oct 1, 2020
22f634f
Update CHANGELOG.md
pracucci Oct 2, 2020
d3d69a5
Merge branch 'master' into ua
pracucci Oct 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@
* [ENHANCEMENT] Blocksconvert – Builder: retry block upload before giving up. #3245
* [ENHANCEMENT] Hash ring: added instance registered timestamp to the ring. #3248
* [ENHANCEMENT] Reduce tail latency by smoothing out spikes in rate of chunk flush operations. #3191
* [ENHANCEMENT] User Cortex as User Agent in http requests #3264
* [BUGFIX] No-longer-needed ingester operations for queries triggered by queriers and rulers are now canceled. #3178
* [BUGFIX] Ruler: directories in the configured `rules-path` will be removed on startup and shutdown in order to ensure they don't persist between runs. #3195
* [BUGFIX] Handle hash-collisions in the query path. #3192
Expand Down
3 changes: 3 additions & 0 deletions pkg/configs/client/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ import (
"github.com/go-kit/kit/log/level"
"github.com/prometheus/client_golang/prometheus"
"github.com/prometheus/client_golang/prometheus/promauto"
"github.com/prometheus/common/version"
"github.com/weaveworks/common/instrument"

"github.com/cortexproject/cortex/pkg/configs/userconfig"
Expand Down Expand Up @@ -140,6 +141,8 @@ func doRequest(endpoint string, timeout time.Duration, tlsConfig *tls.Config, si
client.Transport = &http.Transport{TLSClientConfig: tlsConfig}
}

req.Header.Set("User-Agent", fmt.Sprintf("Cortex/%s", version.Version))

resp, err := client.Do(req)
if err != nil {
return nil, err
Expand Down