Skip to content

Conversation

jtlisi
Copy link
Contributor

@jtlisi jtlisi commented Sep 18, 2020

What this PR does:

It's rare but I've noticed some flake on an integration test that is caused by a querier's worker not connecting to the frontend before the test finishes. This should help solve that issue.

Which issue(s) this PR fixes:
Fixes #3206

Checklist

  • Tests updated
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Signed-off-by: Jacob Lisi <[email protected]>
@jtlisi jtlisi marked this pull request as ready for review September 18, 2020 16:14
Copy link
Contributor

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Contributor

@pstibrany pstibrany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pstibrany pstibrany merged commit 0a33f9d into cortexproject:master Sep 21, 2020
@pracucci pracucci deleted the 20200918_fix_flak branch September 21, 2020 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flaky integration test -- TestQuerierNoSharding

3 participants