Skip to content

Conversation

pstibrany
Copy link
Contributor

What this PR does: This PR adds some improvements to blocksconvert suite:

  • builders now export timestamp of current plan (each plan is for single day, this day's timestamp is exported)
  • obsolete progress files now end up converted to error files by scheduler, not just deleted. This avoids crash looping of builders trying to build the same plan.
  • scheduler now exports metrics about its queue: length, oldest/newest plan day timestamp
  • scanner has new -scanner.allowed-users flag to only generate plans for selected users

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Signed-off-by: Peter Štibraný <[email protected]>
Otherwise builders will try to build same plan again,
and possibly crash again, in a loop.

Signed-off-by: Peter Štibraný <[email protected]>
Copy link
Contributor

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@pracucci pracucci merged commit cbaf36e into cortexproject:master Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants