Add validation of Alertmanager configs to API #3053
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pracucci
reviewed
Aug 18, 2020
gouthamve
force-pushed
the
validate-am-config
branch
2 times, most recently
from
b634a40 to
3251441
Compare
gotjosh
reviewed
Aug 18, 2020
gotjosh
reviewed
Aug 19, 2020
pracucci
approved these changes
Aug 19, 2020
There was a problem hiding this comment.
Good job @gouthamve! I left few nits I would be glad if could take a look, but consider it already approved from me.
gouthamve
force-pushed
the
validate-am-config
branch
from
c87e309 to
ab90318
Compare
gotjosh
approved these changes
Aug 20, 2020
We current reply with a 200/201 even if bad config is applied. This fixes that. Signed-off-by: Goutham Veeramachaneni <[email protected]>
Signed-off-by: Goutham Veeramachaneni <[email protected]>
Signed-off-by: Goutham Veeramachaneni <[email protected]>
Signed-off-by: Goutham Veeramachaneni <[email protected]>
Signed-off-by: Goutham Veeramachaneni <[email protected]>
gouthamve
force-pushed
the
validate-am-config
branch
from
bd9c8d9 to
47b567b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We current reply with a 200 even if bad config is applied. This
fixes that.
Signed-off-by: Goutham Veeramachaneni [email protected]