Additional GRPC stats #3036
Closed
Additional GRPC stats #3036
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
Fixed test for connected clients. Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
pracucci
reviewed
Aug 14, 2020
Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
|
Converted to draft until fate of weaveworks/common#196 is known. It would replace this PR. |
|
I reviewed in ww/common, LGTM there. Feel free to re-add me when thats merged. |
jtlisi
reviewed
Aug 19, 2020
|
|
||
| return &grpcStatsHandler{ | ||
| connectedClients: promauto.With(r).NewGauge(prometheus.GaugeOpts{ | ||
| Name: "cortex_grpc_connected_clients", |
There was a problem hiding this comment.
Suggestion(non-blocking): This struct has a large potential for reuse in other projects. Would you mind making the cortex prefix a configurable namespace?
There was a problem hiding this comment.
Thanks for suggestion. I plan to drop this PR if/when weaveworks/common#196 gets merged. If weaveworks/common#196 doesn't get accepted, I will reconsider this feedback.
|
Closing in favor of #3064, which includes similar enhancements. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does: This PR introduces new gRPC-related metrics:
cortex_grpc_connected_clients– number of connected grpc clients to servercortex_grpc_inflight_requests– number of inflight requests per methodcortex_grpc_method_errors_total– number of errors returned by each methodcortex_grpc_received_payload_size_bytes– histogram for incoming messages, per methodcortex_grpc_sent_payload_size_bytes– histogram for outgoing messages, per methodHeaders and trailers are not tracked, as it's difficult to correctly measure their size, and Cortex doesn't use them anyway.
Bucket sizes for histogram are based on default values used by Cortex (4 MB message size).
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]