Query /series from ingesters regardless the -querier.query-ingesters-within setting #3035
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codesome
approved these changes
Aug 14, 2020
gouthamve
approved these changes
Aug 14, 2020
…range Signed-off-by: Marco Pracucci <[email protected]>
pracucci
force-pushed
the
fix-series-and-labels-querying
branch
from
5c51580 to
8c2c907
Compare
This was referenced Aug 14, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
In #2904 I've introduced a bug which prevents
/seriesrequests to be sent to ingesters if the request time range is older then-querier.query-ingesters-within. This is an unintended regression which this PR should fix.I've run both new unit test and integration test with
master, and they both break (both for chunks and blocks storage).Which issue(s) this PR fixes:
Fixes #3032
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]