Skip to content

Add chunk flush outcome "Dropped", for short series #2998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 10, 2020
Merged

Add chunk flush outcome "Dropped", for short series #2998

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aeec0b8
Add chunk flush outcome "Dropped", for short series
bboreham Aug 5, 2020
857b8b4
Merge branch 'master' into outcome-dropped
pracucci Aug 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions pkg/ingester/flush.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,7 @@ const (
noSeries
noChunks
flushError
reasonDropped
maxFlushReason // Used for testing String() method. Should be last.
)

Expand Down Expand Up @@ -138,6 +139,8 @@ func (f flushReason) String() string {
return "NoChunksToFlush"
case flushError:
return "FlushError"
case reasonDropped:
return "Dropped"
default:
panic("unrecognised flushReason")
}
Expand Down Expand Up @@ -307,12 +310,17 @@ func (i *Ingester) flushUserSeries(flushQueueIndex int, userID string, fp model.
"queue", flushQueueIndex,
)
chunks = nil
reason = reasonDropped
}
}
}

userState.fpLocker.Unlock(fp)

if reason == reasonDropped {
return reason, nil
}

// No need to flush these chunks again.
for len(chunks) > 0 && chunks[0].flushed {
chunks = chunks[1:]
Expand Down