Skip to content

Conversation

@pstibrany
Copy link
Contributor

@pstibrany pstibrany commented May 11, 2020

What this PR does: Release 1.1 preparation. I did initial changelog review.

Based on master 1ea1d19.

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

pstibrany added 2 commits May 11, 2020 15:57
Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
Copy link
Contributor

@codesome codesome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC, you first make these changes in your own branch and open a PR against the release branch (release-1.1 here). Once it is released from the release branch, you then open a PR for merging the release branch to master.

@pstibrany
Copy link
Contributor Author

IIUC, you first make these changes in your own branch and open a PR against the release branch (release-1.1 here).

Hmm, should I start over then? :)

@codesome
Copy link
Contributor

Hmm, should I start over then? :)

I think so :) Also #2578 (comment), you will have to clear these new commits from release-1.1 too and have commits only via a PR to that branch. (Do other maintainers agree with me? :) )

@pstibrany
Copy link
Contributor Author

OK. I will close this one, push changes to my own branch and create PR to merge it into release-1.1 branch. Thanks @codesome!

@pstibrany pstibrany closed this May 11, 2020
@pstibrany pstibrany deleted the release-1.1 branch May 11, 2020 14:25
@pstibrany
Copy link
Contributor Author

Moved to #2579

@pstibrany pstibrany changed the title Release 1.1 Preparation for release 1.1 [wrong, reopened as 2579] May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants