include Cortex version in cortex_build_info #2468
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thorfour
force-pushed
the
build-info-version
branch
2 times, most recently
from
c2437ac to
e79b3f7
Compare
thorfour
force-pushed
the
build-info-version
branch
from
e79b3f7 to
ca93c1b
Compare
|
I've update the Makefile to use the short revision format, but I don't think there's any value in using |
pstibrany
approved these changes
Apr 17, 2020
|
Shall we have CHANGELOG entry for this? |
Signed-off-by: Thor <[email protected]>
Signed-off-by: Marco Pracucci <[email protected]>
pracucci
force-pushed
the
build-info-version
branch
from
cbe7ab2 to
c7c5e8a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does: Adds the version,branch,revision to the build args, so that
cortex_build_infocorrectly populates the version number.Fixes #1709
cortex_build_info{branch="build-info-version",goversion="go1.13.3",revision="ca93c1b87",version="1.0.0"} 1Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]