Enable WAL checkpoint by default #2416
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pracucci
reviewed
Apr 8, 2020
pracucci
reviewed
Apr 8, 2020
codesome
force-pushed
the
wal-doc
branch
2 times, most recently
from
f9902d9 to
ef021d4
Compare
pracucci
approved these changes
Apr 8, 2020
gouthamve
approved these changes
Apr 8, 2020
Signed-off-by: Ganesh Vernekar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no mechanism to delete the old WAL yet if checkpoint is disabled. It should be clearly stated for
-ingester.checkpoint-enabledso that it is not set tofalsefor production or extended dev usage.