Skip to content

Remove tight loop from alertmanager init() #2179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 24, 2020
Merged

Remove tight loop from alertmanager init() #2179

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
756f2d1
Remove tight loop from alertmanager init()
bboreham Feb 24, 2020
43830c4
Rewrite 'for...select' as 'for range' to please lint
bboreham Feb 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 4 additions & 9 deletions pkg/alertmanager/alertmanager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,15 +72,10 @@ var webReload = make(chan chan error)

func init() {
go func() {
for {
select {
// Since this is not a "normal" Alertmanager which reads its config
// from disk, we just ignore web-based reload signals. Config updates are
// only applied externally via ApplyConfig().
case <-webReload:
default:
continue
}
// Since this is not a "normal" Alertmanager which reads its config
// from disk, we just accept and ignore web-based reload signals. Config
// updates are only applied externally via ApplyConfig().
for range webReload {
}
}()
}
Expand Down