Skip to content

Conversation

csmarchbanks
Copy link
Contributor

@csmarchbanks csmarchbanks commented Jun 20, 2019

Lets just do it!

These instructions are based on the Prometheus instructions with a few small modifications according to #1402. I set the first release date to be on Tuesday in order for to collect some feedback.

Updated the circle ci deploy job to use the CIRCLE_TAG env var if it is present rather than generating the image name from the commit sha.

@cboggs
Copy link
Contributor

cboggs commented Jun 21, 2019

This seems like a good place to start. Accommodates shepherding from outside Grafana/Weaveworks, which makes sense overall.

LGTM, we'll iterate as we go.

@weeco
Copy link
Contributor

weeco commented Jun 23, 2019

Maybe we should also wait for #1465 to be merged before the release. It renames a flag.

@csmarchbanks
Copy link
Contributor Author

Maybe we should also wait for #1465 to be merged before the release. It renames a flag.
I don't think that should be a blocker, 0.1.x -> 0.2.x is allowed to have breaking changes in it. We will just make sure to document them.

Would love another maintainer or two to take a look at this before I update the dates and do the first release! (@bboreham, @tomwilkie, @gouthamve, @khaines)

@tomwilkie tomwilkie self-requested a review July 11, 2019 14:49
Copy link
Contributor

@bboreham bboreham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cboggs
Copy link
Contributor

cboggs commented Jul 31, 2019

LGTM 👍

@csmarchbanks csmarchbanks merged commit 10a93e8 into master Jul 31, 2019
@csmarchbanks csmarchbanks deleted the release-process branch July 31, 2019 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants