-
Notifications
You must be signed in to change notification settings - Fork 834
Closed
Labels
Description
Based on a conversation from #2383
At the moment, it is not clear what is the lifecycle of a WriteRequest
when pushed to api/v1/prom/push
:
- Which errors are reported; Assuming
Return first validation error on sample ingestion #2383 is merged(got merged 😄), we only send back the first error we encounter when processing samples. - How sample distribution/ingestion works; Samples are validated before distribution. The ones that do not pass validation are simply discarded, and the ones that do pass are processed. If a failure occurs on ingestion (e.g. duplicated timestamp+value) there are multiple scenarios to cover too.
Would we like to cover these?