Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kill Legacy! #514

Merged
merged 2 commits into from
Jul 11, 2017
Merged

Kill Legacy! #514

merged 2 commits into from
Jul 11, 2017

Conversation

toastercup
Copy link
Member

@toastercup toastercup commented Jul 10, 2017

Purpose:

This beastly PR removes almost every scrap of Legacy from Cortex. What remains are some RESTful endpoints so that Beta Cortex data can still be consumed in the short term, as well as the old Localization system, which may come in handy one day. Why are we splitting from Legacy? We're going to overhaul Users and Tenancy. Legacy makes too many assumptions about how Users/Tenancy works, and would need to be overhauled alongside these changes. This is too great a burden, so Legacy is officially going away.

JIRA:

N/A

Steps to Take On Prod

We will need new production servers for Legacy, as well as new subdomains/ssl certs for legacy. We will want to migrate Legacy data over to these new servers, as well. We'll want to hold off on all of us this until we bake in basic user management into the Beta Cortex interface.

Edit: actually, we may want to create new servers for Beta Cortex, as deleting migrations means we need to re-create the DBs from scratch. Legacy stacks will simply be renamed. All Dev, Staging and Feature stacks will also need to be re-created.

Changes:

  • Changes to setup

    • Oh, you know... "stuff".
  • Architectural changes

    • N/A
  • Migrations

    • Yes! In fact, we've /removed/ Legacy migrations. This is mainly as a benefit to our future Open Source users, who don't want these crufty migrations present when hunting down problems.
  • Library changes

    • N/A
  • Side effects

    • N/A

Screenshots

  • Before
    N/A

  • After
    N/A

QA Links:

http://web.cortex-6.development.c66.me/

How to Verify These Changes

  • Specific pages to visit

    • N/A
  • Steps to take

    • Ensure you can login & Beta Cortex features still work as expected
  • Responsive considerations

    • N/A

Relevant PRs/Dependencies:

N/A

Additional Information

N/A

Copy link

@mrfantasticwonders mrfantasticwonders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, features appear to still be working as they should.

@toastercup toastercup merged commit 1a9cede into develop Jul 11, 2017
@toastercup toastercup deleted the kill-legacy branch July 11, 2017 16:36
@toastercup toastercup removed the legacy label Aug 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants