-
Notifications
You must be signed in to change notification settings - Fork 6
COR-710: Publish System Rebuild #487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
5f9d299
refactor: move down to two states
ElliottAYoung 1e0dd41
refactor: remove unused publishing method and job
ElliottAYoung 506d8ca
feat: build custom content approach to publishing workflow
ElliottAYoung ae224f0
feat: handle timezone through DatePicker
ElliottAYoung 49f221b
fix: clear state cache on update
ElliottAYoung cfac6ca
refactor: remove previous button logic for publish
ElliottAYoung 4856669
feat: add working expiration date to content_item
ElliottAYoung 0eb39aa
refactor: limit cache time on state
ElliottAYoung 6d8f066
chore: add categories - per @justin3thompson
ElliottAYoung 5f64af6
chore: change save button text - per @justin3thompson
ElliottAYoung dbd7f93
feat: create DSL for content_items with #method_missing
ElliottAYoung b32cd67
refactor: necessary pub system renamings and refactors
ElliottAYoung ea21a4f
refactor: clean publish service and add method_missing comments
ElliottAYoung 7900600
feat: implement hybrid approach for state system
ElliottAYoung ae62c0e
Merge branch 'develop' into topic/COR-710-Publish-System-Rebuild
ElliottAYoung File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
class PublishStateService < ApplicationService | ||
def content_item_state(content_item) | ||
@content_item = content_item | ||
|
||
active_state | ||
end | ||
|
||
private | ||
|
||
def active_state | ||
sorted_field_items.each do |field_item| | ||
if !field_item.data['timestamp'].blank? && DateTime.now > DateTime.parse(field_item.data["timestamp"]) | ||
return field_item.field.metadata["state"] | ||
break | ||
end | ||
end | ||
|
||
return @content_item.state.titleize | ||
end | ||
|
||
def sorted_field_items | ||
@sorted_field_items ||= @content_item.field_items.select { |fi| fi.field.field_type_instance.is_a?(DateTimeFieldType) && !fi.field.metadata["state"].nil? }.sort_by{ |a| a.data["timestamp"] }.reverse | ||
end | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since our terminology is 'published', should this be
active_state
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Our terminology is only published for this specific
ContentType
, this method is only trying to figure out which, of the potentially multiple states, is presently active