Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't include tag if not needed #52

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

jssuttles
Copy link

#43
{
untilTag: {
tag: '',
include: false
}
}
untilTag option now takes object like above or string like before

@yagni
Copy link
Collaborator

yagni commented Aug 2, 2016

Is c55297f necessary? You can already tell if a byteArrayParser is big or little endian by comparing it to the dicomParser.bigEndianByteArrayParser and dicomParser.littleEndianByteArrayParser objects directly.

@jssuttles
Copy link
Author

Probably didn't need to push that to this pull request, however, if the dicomWriter that I wrote is to understand whether data is to be handled with little endian or big endian without having to look at the data itself, then it's a really nice helper. The dicomWriter, then, doesn't need to require the dicomParser, so that it can compare the parsers.

@jssuttles jssuttles changed the title Don't include tag if not not needed Don't include tag if not needed Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants