-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Admin Contact Page Frontend & Status #389
Conversation
[diff-counting] Significant lines: 551. |
- Implemented Can't Find Apartment card style display - Implemented Contact Questions card style display
d742e0f
to
3735a6d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a nice start to your task, the formatting of the frontend is clean. Since this is a WIP PR, don't forget to include the word "WIP" in your PR title so that Git doesn't allow automatic merging after an approval review. Also as you complete this sprint task, make sure to remember to format the photos in a similar way to the admin review cards.
This is what it currently looks like in your PR:
This is what the admin review card photo format looks like:
Be sure to try to match the styling of the cards to the admin review cards as much as possible too such as the drop shadows etc.
- Matched the photo display style of Can't Find Apartment Data to match admin reviews - Matched the photo carousel display view - Added documentation for AdminCantFindApt component - Added documentation for AdminContactQuestion component
- Implemented change status buttons to data cards - Implemented status update endpoints
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your documentations, especially in backend/src/app.ts, are extensive and very clear! The new admin page frontend is done very well and significantly improves the usability of the admin contacts page. The backend and database changes were also implemented as required of the task. Good job!
Summary
This pull request is the first step towards implementing frontend style update for the admin contact page information, specifically the pending-buildings data and the contact questions, as well as the status control feature for these data reports.
This feature could improve the organization of the "Can't Find Apartment Data" and "Contact Questions". Admin can also easily identify the information and make their decisions in whether to delete (DELETE) or complete (COMPLETE) the report, changing the display and status of these information
Test Plan
Breaking Changes
CantFindApartmentFormWithId
type andQuestionFormWithId
type indb-types.ts