Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin Contact Page Frontend & Status #389

Merged
merged 6 commits into from
Mar 2, 2025
Merged

Conversation

CasperL1218
Copy link
Contributor

@CasperL1218 CasperL1218 commented Feb 10, 2025

Summary

This pull request is the first step towards implementing frontend style update for the admin contact page information, specifically the pending-buildings data and the contact questions, as well as the status control feature for these data reports.

This feature could improve the organization of the "Can't Find Apartment Data" and "Contact Questions". Admin can also easily identify the information and make their decisions in whether to delete (DELETE) or complete (COMPLETE) the report, changing the display and status of these information

  • implemented card style display with status buttons for the "Can't Find Apartment Data"
  • implemented card style display with status buttons for the "Contact Questions"
  • implemented backend for handling status update of the data/reports with update PUT endpoints

Test Plan

admin pending building (1) "Can't Find Apartment Data" card display with status buttons admin pending building photo (2) "Can't Find Apartment Data" photo carousel admin contact questions (3) "Contact Questions" card display with status buttons

Breaking Changes

  • Database schema change
    • Defined CantFindApartmentFormWithId type and QuestionFormWithId type in db-types.ts

@dti-github-bot
Copy link
Member

dti-github-bot commented Feb 10, 2025

[diff-counting] Significant lines: 551.

- Implemented Can't Find Apartment card style display
- Implemented Contact Questions card style display
@CasperL1218 CasperL1218 force-pushed the admin-contact-page-frontend branch from d742e0f to 3735a6d Compare February 10, 2025 02:05
Copy link
Contributor

@ggsawatyanon ggsawatyanon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice start to your task, the formatting of the frontend is clean. Since this is a WIP PR, don't forget to include the word "WIP" in your PR title so that Git doesn't allow automatic merging after an approval review. Also as you complete this sprint task, make sure to remember to format the photos in a similar way to the admin review cards.
This is what it currently looks like in your PR:
image
This is what the admin review card photo format looks like:
image

Be sure to try to match the styling of the cards to the admin review cards as much as possible too such as the drop shadows etc.

@CasperL1218 CasperL1218 changed the title Admin Contact Page Frontend WIP: Admin Contact Page Frontend Feb 10, 2025
- Matched the photo display style of Can't Find Apartment Data to match admin reviews
- Matched the photo carousel display view
- Added documentation for AdminCantFindApt component
- Added documentation for AdminContactQuestion component
- Implemented change status buttons to data cards
- Implemented status update endpoints
@CasperL1218 CasperL1218 changed the title WIP: Admin Contact Page Frontend Admin Contact Page Frontend & Status Feb 27, 2025
Copy link
Contributor

@ggsawatyanon ggsawatyanon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your documentations, especially in backend/src/app.ts, are extensive and very clear! The new admin page frontend is done very well and significantly improves the usability of the admin contacts page. The backend and database changes were also implemented as required of the task. Good job!

@ggsawatyanon ggsawatyanon merged commit 9f73819 into main Mar 2, 2025
3 checks passed
@ggsawatyanon ggsawatyanon deleted the admin-contact-page-frontend branch March 2, 2025 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants