Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix download links for binaries #47

Merged
merged 1 commit into from
Jan 16, 2020

Conversation

vadasambar
Copy link
Contributor

No description provided.

@corneliusweig
Copy link
Owner

Hey @vadasambar, thanks for finding this and providing the fix.

Could you please sign-off your commit as described here? https://github.com/corneliusweig/ketall/blob/master/CONTRIBUTING.md#pull-request-checklist

This should do it:

git commit --amend --signoff
git push --force-with-lease

Signed-off-by: Suraj Banakar <[email protected]>
@codecov-io
Copy link

codecov-io commented Jan 16, 2020

Codecov Report

Merging #47 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #47   +/-   ##
=======================================
  Coverage   41.81%   41.81%           
=======================================
  Files           9        9           
  Lines         385      385           
=======================================
  Hits          161      161           
  Misses        202      202           
  Partials       22       22

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c521886...108f5f8. Read the comment docs.

@vadasambar
Copy link
Contributor Author

Thank you @corneliusweig ! I have signed the commit

@corneliusweig corneliusweig changed the title fix download links for binaries Fix download links for binaries Jan 16, 2020
@corneliusweig corneliusweig merged commit 3e2dc04 into corneliusweig:master Jan 16, 2020
@corneliusweig
Copy link
Owner

Thanks again for contributing!

Btw, I personally recommend to install via krew.dev 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants