-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[travis] Remove obsolete GOPROXY
and GO111MODULE
setting
#40
Conversation
Codecov Report
@@ Coverage Diff @@
## master #40 +/- ##
=======================================
Coverage 41.88% 41.88%
=======================================
Files 9 9
Lines 382 382
=======================================
Hits 160 160
Misses 200 200
Partials 22 22 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but GO111MODULE is also obsolete for 1.13 because auto enables GOPATH aware.
😆 I should have known |
GOPROXY
settingGOPROXY
and GO111MODULE
setting
@ferhatelmas Do you want to suggest a fix for |
Good idea, will send a PR for it. |
Just remember to also include a link to the relevant docs |
Maybe better to create an issue with doc links then resolve it via a PR. What do you think? |
I think it doesn't really matter, as it's a small thing. Your call :) |
Btw, I pinged ?you? on kubernetes slack. |
Will be more online there, replied now. |
The setting just re-iterated the go-1.13 default.
Thanks @ferhatelmas for spotting this!