Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[travis] Remove obsolete GOPROXY and GO111MODULE setting #40

Merged
merged 2 commits into from
Nov 15, 2019

Conversation

corneliusweig
Copy link
Owner

The setting just re-iterated the go-1.13 default.

Thanks @ferhatelmas for spotting this!

@codecov-io
Copy link

codecov-io commented Nov 15, 2019

Codecov Report

Merging #40 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #40   +/-   ##
=======================================
  Coverage   41.88%   41.88%           
=======================================
  Files           9        9           
  Lines         382      382           
=======================================
  Hits          160      160           
  Misses        200      200           
  Partials       22       22

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f015df5...bc77b2f. Read the comment docs.

Copy link

@ferhatelmas ferhatelmas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but GO111MODULE is also obsolete for 1.13 because auto enables GOPATH aware.

@corneliusweig
Copy link
Owner Author

😆 I should have known

@corneliusweig corneliusweig changed the title Remove obsolete GOPROXY setting [travis] Remove obsolete GOPROXY and GO111MODULE setting Nov 15, 2019
@corneliusweig
Copy link
Owner Author

@ferhatelmas Do you want to suggest a fix for krew as well?

@ferhatelmas
Copy link

Good idea, will send a PR for it.

@corneliusweig
Copy link
Owner Author

Good idea, will send a PR for it.

Just remember to also include a link to the relevant docs

@corneliusweig corneliusweig merged commit cfd7590 into master Nov 15, 2019
@corneliusweig corneliusweig deleted the w/remove-obsolete-goproxy branch November 15, 2019 13:23
@ferhatelmas
Copy link

Maybe better to create an issue with doc links then resolve it via a PR. What do you think?

@corneliusweig
Copy link
Owner Author

I think it doesn't really matter, as it's a small thing. Your call :)

@corneliusweig
Copy link
Owner Author

corneliusweig commented Nov 15, 2019

Btw, I pinged ?you? on kubernetes slack.

@ferhatelmas
Copy link

Will be more online there, replied now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants