feat: comment on threshold should be more alarming

[touchweb-vincent]

Hello,

Just to be consistent with this : https://github.com/coreruleset/coreruleset/pull/4330/files

[EsadCetiner]

Please do not resolve comments that you haven't properly addressed, if you don't understand my request or disagree with it please speak up instead of marking it as resolved.

Right now your changes are very wordy, and is even confusing in some places.

[touchweb-vincent]

I’ve responded to all your points. I understood from another PR that you - or at least Max - preferred having discussions marked as resolved so you can keep track of progress. I can handle it differently with you if you prefer.

I’m now waiting for your feedback on my responses.

[EsadCetiner]

@touchweb-vincent

I’ve responded to all your points.

I've tagged you in the comments you haven't addressed, I'm still waiting on them.

you - or at least Max - preferred having discussions marked as resolved so you can keep track of progress.

Yes, but you only mark a discussion marked as resolved once you are finished with it. Meaning you applied the suggestion, if you disagree with a suggestion or don't understand it you don't mark it as resolved, you ask follow up questions or express your disagreement until an agreement is come to.

[touchweb-vincent]

I’ve given you detailed explanations about why I disagreed with some points, and the two change requests have been marked as unresolved. I’m now waiting for your feedback.

[EsadCetiner]

I’ve given you detailed explanations about why I disagreed with some points

I don't see where you gave such an explanation, all I see are my own comments

[touchweb-vincent]

[touchweb-vincent]

I don't understand why you don't see it.

[EsadCetiner]

@touchweb-vincent You haven't published your review, that's why it says "Pending" in orange above your message.

You need to publish your review, you can do that by clicking the files tab and "submit review" at the top right:

[touchweb-vincent]

I had never seen this GitHub behavior in the past 3 years! Thank you!

[EsadCetiner]

Thank you, I understand your changes much better now. How do these suggestions sound?