Skip to content
This repository has been archived by the owner on Sep 22, 2020. It is now read-only.

Allow size as a percent for torusd. Fixes #175 #278

Merged
merged 3 commits into from
Sep 8, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 40 additions & 4 deletions cmd/torusd/main.go
Original file line number Diff line number Diff line change
@@ -1,13 +1,18 @@
package main

import (
"errors"
"fmt"
"net/url"
"os"
"os/signal"
"path/filepath"
"strconv"
"strings"

"github.com/coreos/pkg/capnslog"
"github.com/dustin/go-humanize"
"github.com/ricochet2200/go-disk-usage/du"
"github.com/spf13/cobra"

"github.com/coreos/torus"
Expand Down Expand Up @@ -110,10 +115,29 @@ func configureServer(cmd *cobra.Command, args []string) {
fmt.Fprintf(os.Stderr, "error parsing read-cache-size: %s\n", err)
os.Exit(1)
}
size, err = humanize.ParseBytes(sizeStr)
if err != nil {
fmt.Fprintf(os.Stderr, "error parsing size: %s\n", err)
os.Exit(1)
if strings.Contains(sizeStr, "%") {

percent, err := parsePercentage(sizeStr)
if err != nil {
fmt.Fprintf(os.Stderr, "error parsing size: %s\n", err)
os.Exit(1)
}

directory := dataDir
if dataDir == "" {
directory, _ = os.Getwd()
} else {
directory, _ = filepath.Abs(dataDir)
}

size = du.NewDiskUsage(directory).Size() * percent / 100

} else {
size, err = humanize.ParseBytes(sizeStr)
if err != nil {
fmt.Fprintf(os.Stderr, "error parsing size: %s\n", err)
os.Exit(1)
}
}

var rl torus.ReadLevel
Expand Down Expand Up @@ -151,6 +175,18 @@ func configureServer(cmd *cobra.Command, args []string) {
}
}

func parsePercentage(percentString string) (uint64, error) {
sizePercent := strings.Split(percentString, "%")[0]
sizeNumber, err := strconv.Atoi(sizePercent)
if err != nil {
return 0, err
}
if sizeNumber < 1 || sizeNumber > 100 {
return 0, errors.New("invalid size; must be between 1%% and 100%%\n")
}
return uint64(sizeNumber), nil
}

func runServer(cmd *cobra.Command, args []string) {

var (
Expand Down
2 changes: 2 additions & 0 deletions glide.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions glide.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ import:
- package: github.com/prometheus/client_golang
subpackages:
- prometheus
- package: github.com/ricochet2200/go-disk-usage
- package: github.com/serialx/hashring
- package: github.com/spf13/cobra
- package: golang.org/x/net
Expand Down
6 changes: 6 additions & 0 deletions local_server.go
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,12 @@ func NewServer(cfg Config, metadataServiceKind, blockStoreKind string) (*Server,
return nil, err
}

offset := cfg.StorageSize % global.BlockSize
if offset != 0 {
cfg.StorageSize = cfg.StorageSize - offset
clog.Infof("resizing to %v bytes to make an even multiple of blocksize: %v\n", cfg.StorageSize, global.BlockSize)
}

blocks, err := CreateBlockStore(blockStoreKind, "current", cfg, global)
if err != nil {
return nil, err
Expand Down