This repository was archived by the owner on Feb 5, 2020. It is now read-only.
kube_version: update for installer integration#13
Merged
squeed merged 2 commits intocoreos:masterfrom Aug 11, 2017
lucab:ups/kube-version
Merged
kube_version: update for installer integration#13squeed merged 2 commits intocoreos:masterfrom lucab:ups/kube-version
squeed merged 2 commits intocoreos:masterfrom
lucab:ups/kube-version
Conversation
squeed
reviewed
Aug 10, 2017
internal/kube_version.go
Outdated
| return nil | ||
| } | ||
|
|
||
| // GetKubeVersion retrieves kubernetes version querying several sources |
squeed
suggested changes
Aug 10, 2017
internal/kube_version.go
Outdated
| ) | ||
|
|
||
| // WriteKubeletEnv writes the `kubelet.env` file | ||
| func (a *App) WriteKubeletEnv(destPath string) error { |
There was a problem hiding this comment.
This needs to write the kubernetes version from the API if available.
squeed
reviewed
Aug 11, 2017
| defer dstFp.Close() | ||
|
|
||
| for k, v := range flags { | ||
| if k == envVersionKey && kubeletVersion != "" { |
There was a problem hiding this comment.
Do you want to add the versionKey if its not present in the file?
Contributor
Author
There was a problem hiding this comment.
Mmh, an emergency fallback would not hurt.
After some more thinking, I prefer to let the kubelet service fail to start in such cases. Otherwise debugging what's wrong here can be quite hard.
|
One small question, otherwise LGTM. Feel free to merge. |
Contributor
Author
|
coreos/tectonic-installer#1659 is a pre-requisite for this. |
squeed
approved these changes
Aug 11, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.