This repository was archived by the owner on Feb 5, 2020. It is now read-only.
Release script fixes #609
Merged
Release script fixes #609
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
May 9, 2017 11:22
For executing & testing scripts via our build container for consistent builds.
Quentin-M
approved these changes
May 9, 2017
wking
added a commit
to wking/openshift-installer
that referenced
this pull request
Sep 10, 2018
This script is from f7103ba (build: add back builder-run utility script, 2017-05-09, coreos/tectonic-installer#609), but doesn't seem to have ever been used anywhere. With installer/scripts gone since 7296010 (frontend: Remove frontend code and backend API code, 2018-04-06, coreos/tectonic-installer#3067), I think we can just drop builder-run entirely.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran into some issues whey trying to cut a release. Details are in the comments.