Skip to content
This repository was archived by the owner on Feb 5, 2020. It is now read-only.

clean up ruby tests#3288

Closed
enxebre wants to merge 1 commit intocoreos:masterfrom
enxebre:tests-cleanup
Closed

clean up ruby tests#3288
enxebre wants to merge 1 commit intocoreos:masterfrom
enxebre:tests-cleanup

Conversation

@enxebre
Copy link
Contributor

@enxebre enxebre commented Jun 13, 2018

remove tests unused code and cluster abstraction

@coreosbot
Copy link

Can one of the admins verify this patch?

Copy link
Contributor

@paulfantom paulfantom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New rspec framework is in completly different directory, so why bother with making changes to old one?

@enxebre
Copy link
Contributor Author

enxebre commented Jun 13, 2018

retest this please

@enxebre
Copy link
Contributor Author

enxebre commented Jun 13, 2018

this is just a quick cleanup of old files on the solution which is currently in place, once we got a new solution working we can completely remove it

@squat
Copy link
Contributor

squat commented Jun 13, 2018

@enxebre looks like rubocop is complaining:

rubocop --cache false spec lib
Inspecting 23 files
..............W........

Offenses:

lib/aws_cluster.rb:123:7: C: Align the elements of an array literal if they span more than one line.
      variables['TF_VAR_tectonic_cluster_name'] = @name,
      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/aws_cluster.rb:124:7: C: Align the elements of an array literal if they span more than one line.
      variables['TF_VAR_tectonic_admin_email'] = @tectonic_admin_email,
      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/aws_cluster.rb:125:7: C: Align the elements of an array literal if they span more than one line.
      variables['TF_VAR_tectonic_admin_password'] = @tectonic_admin_password
      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/aws_cluster.rb:353:3: W: Useless private access modifier.
  private
  ^^^^^^^

23 files inspected, 4 offenses detected

@enxebre enxebre force-pushed the tests-cleanup branch 5 times, most recently from 10526d0 to a7961a6 Compare June 13, 2018 19:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants