This repository was archived by the owner on Feb 5, 2020. It is now read-only.
cli: populate core config#2982
Merged
enxebre merged 1 commit intocoreos:ut2-integrationfrom Feb 19, 2018
Merged
Conversation
|
Can one of the admins verify this patch? |
Contributor
Author
|
@spangenberg I'm not sure there's a better way to set this "default" non user input values. If this is a valid approach we could also move them to constants |
alexsomesan
approved these changes
Feb 19, 2018
squat
approved these changes
Feb 19, 2018
Contributor
squat
left a comment
squat
left a comment
There was a problem hiding this comment.
looks good for now. we should follow up and clean up the hardcoded values
enxebre
added a commit
to enxebre/tectonic-installer
that referenced
this pull request
Feb 19, 2018
cli: populate core config
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fills unpopulated core config fields