This repository was archived by the owner on Feb 5, 2020. It is now read-only.
remove bootstrap ignition as part of rm-assets#2958
Merged
enxebre merged 1 commit intocoreos:ut2-integrationfrom Feb 16, 2018
Merged
remove bootstrap ignition as part of rm-assets#2958enxebre merged 1 commit intocoreos:ut2-integrationfrom
enxebre merged 1 commit intocoreos:ut2-integrationfrom
Conversation
|
Can one of the admins verify this patch? |
alexsomesan
reviewed
Feb 16, 2018
| set -o pipefail | ||
| REGION=$(wget -q -O - http://169.254.169.254/latest/meta-data/placement/availability-zone | sed '"'"'s/[a-zA-Z]$//'"'"') | ||
| /usr/bin/aws --region="$REGION" s3 cp /tmp/assets.zip s3://"$LOCATION" | ||
| /usr/bin/aws --region="$REGION" s3 cp /tmp/assets.zip s3://"$LOCATION/assets.zip" |
Contributor
There was a problem hiding this comment.
I think we actually want to invalidate both assets.zip and ignition.
Would something like echo > ignition and echo > assets.zip before each cp operation work for that?
Contributor
Author
There was a problem hiding this comment.
isn't what we are doing by touch /tmp/assets.zip? I can rename if it's not clear
Contributor
There was a problem hiding this comment.
Unless /tmp/assets.zip doesn't already exist.
In that case it just gets it's timestamps updated and ends up being uploaded to S3.
Not the right time and place to obsess about edge cases tough, so this might be nitpicking.
alexsomesan
approved these changes
Feb 16, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
overwrite bootstrap ignition as part of rm-assets service