This repository was archived by the owner on Feb 5, 2020. It is now read-only.
add multistep support for the cli - WIP - DO NOT MERGE#2949
Merged
alexsomesan merged 2 commits intocoreos:ut2-integrationfrom Feb 15, 2018
Merged
add multistep support for the cli - WIP - DO NOT MERGE#2949alexsomesan merged 2 commits intocoreos:ut2-integrationfrom
alexsomesan merged 2 commits intocoreos:ut2-integrationfrom
Conversation
|
Can one of the admins verify this patch? |
alexsomesan
reviewed
Feb 14, 2018
| clusterConfigFlag = clusterInstallCommand.Flag("config", "Cluster specification file").Required().ExistingFile() | ||
| dryRunFlag = kingpin.Flag("dry-run", "Just pretend, but don't do anything").Bool() | ||
| clusterInstallCommand = kingpin.Command("install", "Create a new Tectonic cluster") | ||
| clusterFullInstallCommand = clusterInstallCommand.Command("full", "Create a new Tectonic cluster").Default() |
Contributor
There was a problem hiding this comment.
This should be the default path. No need to explicitly have a sub-command.
#lessismore #minimalism
Contributor
Author
There was a problem hiding this comment.
By adding full as default the user can just run cli install --config otherwise the same command complains about it expecting a subcommand. Not sure yet how to tell kingpin that the subcommand is not mandatory
alexsomesan
approved these changes
Feb 14, 2018
spangenberg
approved these changes
Feb 15, 2018
alexsomesan
approved these changes
Feb 15, 2018
enxebre
added a commit
to enxebre/tectonic-installer
that referenced
this pull request
Feb 15, 2018
* add multistep support for the cli * cli: Fix lint
alexsomesan
pushed a commit
to alexsomesan/tectonic-installer
that referenced
this pull request
Feb 21, 2018
* add multistep support for the cli * cli: Fix lint
mxinden
pushed a commit
that referenced
this pull request
Feb 27, 2018
* add multistep support for the cli * cli: Fix lint
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for deploying using a cluster the cli:
cli install --config=terraform.tfvariablescluster-name and platform are currently hardcoded