This repository was archived by the owner on Feb 5, 2020. It is now read-only.
tests/frontend: Better tests for file upload fields and clean up temporary files when tests complete #2926
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
squat
reviewed
Feb 12, 2018
| @@ -0,0 +1,14 @@ | |||
| const fs = require('fs'); | |||
|
|
|||
| exports.command = function (selector, text, textSelector = undefined) { | |||
Contributor
There was a problem hiding this comment.
why are we explicitly setting a default to undefined? this is the default value of any parameter that was not set. moreover, we don't do this anywhere else, I believe
Contributor
Author
There was a problem hiding this comment.
This was just meant to indicate that the parameter is optional, but after looking at it again, I think it's better to move the textarea tests to testFileTextCombo and remove the textSelector parameter completely.
Add setFileField() and testFileTextCombo() custom commands for testing
file upload inputs.
Use the same temporary file location for all file upload tests and
delete that file at the end of the test run. This should prevent
temporary files being left on the file system when the tests exit.
Also improves testing of upload / textarea combos:
- Test that the textarea is populated with the file contents
- Test textarea field validation
- Stop using xpath selectors because all combos now have id attributes
that we can use instead.
kyoto
force-pushed
the
nightwatch-file-tests
branch
from
a210d0e to
6d8794b
Compare
Contributor
Author
|
@squat Could you take another look please? |
squat
reviewed
Feb 19, 2018
| @@ -1,3 +1,5 @@ | |||
| const fs = require('fs'); | |||
|
|
|||
Contributor
There was a problem hiding this comment.
is this extra newline wanted?
Contributor
Author
There was a problem hiding this comment.
We're generally putting a newline between package imports and imports from the same repo.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
setFileField()andtestFileTextCombo()custom commands for testing file upload inputs.Use the same temporary file location for all file upload tests and delete that file at the end of the test run. This should prevent temporary files being left on the file system when the tests exit.
Also improves testing of upload / textarea combos:
idattributes that we can use instead.