This repository was archived by the owner on Feb 5, 2020. It is now read-only.
Conversation
|
Can one of the admins verify this patch? |
Closed
Contributor
|
ok to test |
enxebre
force-pushed
the
govcloud-m
branch
3 times, most recently
from
93a10fb to
6c6f8a6
Compare
|
Can one of the admins verify this patch? |
cpanato
force-pushed
the
govcloud-m
branch
2 times, most recently
from
f32ff88 to
1055761
Compare
sym3tri
reviewed
Dec 22, 2017
| description = "See tectonic_self_hosted_etcd in config.tf" | ||
| } | ||
|
|
||
| variable "tectonic_vanilla_k8s" { |
Contributor
There was a problem hiding this comment.
Will need to remove these once your other PR lands.
Contributor
|
retest this please |
Contributor
|
retest this please |
Contributor
Author
|
retest this please |
Contributor
Author
|
retest this please |
1 similar comment
Contributor
Author
|
retest this please |
Contributor
|
waiting for @sym3tri / @alexsomesan |
spangenberg
approved these changes
Jan 4, 2018
Contributor
spangenberg
left a comment
spangenberg
left a comment
There was a problem hiding this comment.
LGTM with hint to make bastion instance type configurable in the near future.
Contributor
|
ship it |
Contributor
|
@enxebre don't forget to cherry-pick into track-1 |
Contributor
Author
|
track-1 PR #2660 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This introduces support for aws govcloud: