This repository was archived by the owner on Feb 5, 2020. It is now read-only.
Bootstrap #2230
Merged
Bootstrap #2230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
cpanato
added
area/testing
platform/gcp
run-smoke-tests
and removed
area/testing
labels
Contributor
|
ok to test |
Contributor
|
for some weird reason, jenkins is not recognizing the new parameter. I've set up a custom job and run the rspec there |
cpanato
previously approved these changes
Oct 26, 2017
Contributor
cpanato
left a comment
cpanato
left a comment
There was a problem hiding this comment.
Ran in a side jenkins job and GCP tests passed.this LGTM
Contributor
|
@squat / @s-urbaniak / @alexsomesan can you guys take a look here and review? |
Contributor
squat
reviewed
Oct 27, 2017
modules/gcp/master-igm/master.tf
Outdated
| instance_template = "${google_compute_instance_template.master-it.self_link}" | ||
| target_pools = ["${var.master_targetpool_self_link}"] | ||
| base_instance_name = "mstr" | ||
| base_instance_name = "${var.cluster_name}-mstr" |
Contributor
There was a problem hiding this comment.
nit: can we make this fully "master" rather than abbreviated to "mstr"? All other platforms and other resources in this platform use the full word.
modules/gcp/worker-igm/worker.tf
Outdated
| instance_template = "${google_compute_instance_template.worker-it.self_link}" | ||
| target_pools = ["${var.worker_targetpool_self_link}"] | ||
| base_instance_name = "wrkr" | ||
| base_instance_name = "${var.cluster_name}-wrkr" |
Contributor
|
running the gcp tests in the custom job |
squat
approved these changes
Oct 27, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
google_compute_target_tcp_proxygoogle_compute_region_instance_group_managerNote: This need to be rebased once #2178 gets in