This repository was archived by the owner on Feb 5, 2020. It is now read-only.
tests/rspec/lib: ensure CL version is available #2193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squat
force-pushed
the
refactor_cl_version
branch
2 times, most recently
from
8062117 to
4b9a855
Compare
Contributor
Author
|
ok to test |
mxinden
previously approved these changes
Oct 20, 2017
cpanato
previously approved these changes
Oct 20, 2017
Contributor
|
👍 |
Contributor
Author
|
between this run and the last, all of the smoke tests have successfully completed. |
squat
force-pushed
the
refactor_cl_version
branch
from
4b9a855 to
d63535f
Compare
Contributor
Author
|
@cpanato PTAL once more, I removed an extra space between the |
This change ensures that a Container Linux version will be reported even if update-engine has not finished running and creating an `aleph-version' file. If this is the case, we will simple read the version from the canonical location, /usr/share/coreos/release.
Contributor
|
Just run the tests from this branch #2178 and the changes in this PR on GCP and all green |
cpanato
approved these changes
Oct 20, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change ensures that a Container Linux version will be reported even
if update-engine has not finished running and creating an
`aleph-version' file. If this is the case, we will simple read the
version from the canonical location, /usr/share/coreos/release.
cc @cpanato @enxebre