This repository was archived by the owner on Feb 5, 2020. It is now read-only.
modules: unify ignition across platforms#1743
Merged
s-urbaniak merged 13 commits intocoreos:masterfrom Aug 29, 2017
Merged
Conversation
Contributor
|
ok to test |
Contributor
|
ok to test |
s-urbaniak
force-pushed
the
unify-ign
branch
2 times, most recently
from
98d62fd to
d785d36
Compare
lucab
reviewed
Aug 22, 2017
modules/ignition/assets.tf
Outdated
|
|
||
| data "ignition_file" "max_user_watches" { | ||
| filesystem = "root" | ||
| path = "/etc/sysctl.d/max-user-watches.conf" |
Contributor
There was a problem hiding this comment.
Suggestion while at it: use a nn-foo.conf name scheme.
Contributor
|
@s-urbaniak Tests run properly again. |
Contributor
Author
|
@mxinden thanks a lot! |
Contributor
Author
|
ok to test |
2 similar comments
Contributor
Author
|
ok to test |
Contributor
Author
|
ok to test |
s-urbaniak
force-pushed
the
unify-ign
branch
3 times, most recently
from
6decf17 to
441209f
Compare
lucab
reviewed
Aug 24, 2017
platforms/aws/main.tf
Outdated
| kubeconfig_s3_location = "${aws_s3_bucket_object.kubeconfig.bucket}/${aws_s3_bucket_object.kubeconfig.key}" | ||
|
|
||
| kubelet_exec_start_pre = <<EOF | ||
| ExecStartPre=/usr/bin/bash -c "/opt/s3-puller.sh ${aws_s3_bucket_object.kubeconfig.bucket}/${aws_s3_bucket_object.kubeconfig.key} /etc/kubernetes/kubeconfig" |
Contributor
There was a problem hiding this comment.
Nit (maybe for later): I think this bash -c is useless here and just a leftover from a similar line in another service which is doing a redirection.
Contributor
Author
There was a problem hiding this comment.
that is indeed a valid point, I factored bash -c out in this PR.
s-urbaniak
force-pushed
the
unify-ign
branch
2 times, most recently
from
c23d0fe to
55ea75f
Compare
Contributor
Author
|
ok to test |
s-urbaniak
force-pushed
the
unify-ign
branch
5 times, most recently
from
d4ddfd9 to
2c5aca3
Compare
Fixes partially INST-132
added 3 commits
August 28, 2017 09:50
... it is not needed there, only masters are being used for bootstrapping.
s-urbaniak
changed the title
added 2 commits
August 28, 2017 10:19
This adds the same docker options dropin as all the other platforms. Fixes INST-38
Contributor
Author
|
PTAL @alexsomesan |
lucab
suggested changes
Aug 28, 2017
platforms/vmware/main.tf
Outdated
| private_key = "${var.tectonic_vmware_ssh_private_key_path}" | ||
| image_re = "${var.tectonic_image_re}" | ||
|
|
||
| ign_docker_dropin_id = "${module.ignition_masters.docker_dropin_id}" |
Contributor
There was a problem hiding this comment.
s/ignition_masters/ignition_workers/ (here and lines below)
Contributor
Author
There was a problem hiding this comment.
good catch, fixed
Contributor
Author
|
ok to test |
alexsomesan
previously approved these changes
Aug 28, 2017
Contributor
alexsomesan
left a comment
alexsomesan
left a comment
There was a problem hiding this comment.
Looks good!
Glad to see this taking shape.
lucab
approved these changes
Aug 28, 2017
Contributor
lucab
left a comment
lucab
left a comment
There was a problem hiding this comment.
(Casual bystander) LGTM. Checked on my bare-metal playground.
Contributor
Author
|
@lucab your bystanding is highly appreciated :-D |
Contributor
Author
|
ok to test |
1 similar comment
Contributor
Author
|
ok to test |
Contributor
Author
|
ok to test |
Contributor
|
all green now @s-urbaniak |
Contributor
Author
|
@cpanato thanks and kudos for helping with improving CI! |
squat
pushed a commit
to squat/tectonic-installer
that referenced
this pull request
Sep 25, 2017
* modules/ignition: unify max-user-watches Fixes partially INST-132 * modules/ignition: unify docker dropin Fixes partially INST-132 * modules/ignition: unify kubelet * modules/ignition: unify locksmithd service * modules/ignition: unify kubelet.env * modules/ignition: unify tx-off service * modules/ignition: unify 66-azure-storage-rules * moduls/azure: disable stale tectonic service on workers ... it is not needed there, only masters are being used for bootstrapping. * modules/azure: remove stale azure_udev_rules definition * platforms/metal: unify dockeropts with other platforms This adds the same docker options dropin as all the other platforms. Fixes INST-38 * platforms/*: s/ignition_masters/ignition_workers * modules/ignition: apply nn-foo.conf scheme for max-user-watches.conf Fixes coreos#1743 (comment) * modules/vmware: remove stale kubelet-env declaration
nreisbeck
added a commit
to nreisbeck/tectonic-installer
that referenced
this pull request
Oct 19, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes partially INST-132