Skip to content
This repository was archived by the owner on Feb 5, 2020. It is now read-only.

Conversation

@diegs
Copy link
Contributor

@diegs diegs commented Aug 7, 2017

No description provided.

@diegs diegs self-assigned this Aug 7, 2017
@diegs diegs requested a review from Quentin-M August 7, 2017 21:19
@diegs
Copy link
Contributor Author

diegs commented Aug 7, 2017

test upgrade from 1.6.7-tectonic.2 1.6.7-tectonic.2

@Quentin-M
Copy link
Contributor

I was waiting for the tests to pass. They did not get triggered. Oookkay.

@diegs
Copy link
Contributor Author

diegs commented Aug 8, 2017

@Quentin-M azure tests failed, bare metal didn't run?

@Quentin-M
Copy link
Contributor

Quentin-M commented Aug 8, 2017 via email

@diegs
Copy link
Contributor Author

diegs commented Aug 8, 2017

It looks like Azure did fail due to some subscription thing. Up to you how to proceed.

@sym3tri
Copy link
Contributor

sym3tri commented Aug 8, 2017

@diegs @mxinden is looking into Azure failures and should have a fix soon.

Quentin-M
Quentin-M previously approved these changes Aug 8, 2017
@mxinden
Copy link
Contributor

mxinden commented Aug 8, 2017

@diegs Please rebase to current master to have the fixes from #1558 in here.

@Quentin-M
Copy link
Contributor

Smoke tests always automatically rebase on master (thus the name continuous-integration/jenkins/pr-merge). There is no need for him to rebase if you'd like to test that PR with master changes, just re-trigger the tests.

@mxinden
Copy link
Contributor

mxinden commented Aug 8, 2017

@Quentin-M right, forgot about that. Thanks for the reminder. I have retriggered the tests.

@Quentin-M
Copy link
Contributor

Quentin-M commented Aug 8, 2017

The first tests indicate that Azure is still failing.

@mxinden
Copy link
Contributor

mxinden commented Aug 8, 2017

@Quentin-M I am not sure we are rebasing properly onto master. The builds of this PR are still using the test-ext-group, which we deleted in #1558.

This might be due to the simple checkout scm on each worker node that we use instead of the full rebase Jenkins does automatically on the master node.

@Quentin-M
Copy link
Contributor

@mxinden I see! Thank you for the explanation and sorry about the misunderstanding!

@diegs
Copy link
Contributor Author

diegs commented Aug 8, 2017

I will rebase.

@Quentin-M
Copy link
Contributor

Only a single failure on Azure. Cool 👍

@Quentin-M Quentin-M merged commit 5ff4f1a into coreos:master Aug 8, 2017
@diegs diegs deleted the v1.7.1-kvo.5 branch August 8, 2017 20:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants