tests/ci: add upstream-terraform-trigger as jenkins script #1565
Conversation
|
@mxinden I will rebase then we can merge and delete the old job |
|
@mxinden rebased |
cpanato
changed the title
|
@cpanato Can you update the PR to remove the upstream-terraform-trigger.groovy file? |
|
done @mxinden |
|
when we merge this we need delete the old jenkins job |
mxinden
left a comment
mxinden
left a comment
There was a problem hiding this comment.
This looks very neat! Thanks!
|
@cpanato Let's please not delete the old terraform-upstream Jenkins job, because we still want to analyse the test results. |
mxinden
left a comment
mxinden
left a comment
There was a problem hiding this comment.
@cpanato Actually, thinking about this again. The reason we have this trigger is to track, how well the upstream terraform version is performing. Without this trigger to wait for the main pipeline to finish, we don't have any aggregated view to analyse the behaviour of the upstream terraform version.
Could you make this trigger synchronous again so that the trigger fails whenever the main pipeline failed?
Sorry for all the back and forth around the triggers.
|
@mxinden reverted |
mxinden
left a comment
mxinden
left a comment
There was a problem hiding this comment.
Looks good. Thanks for the fix. I like the parameter handling!
|
I have deactivated the old job. I have run the Jenkins seed job. Looks good. Running right now here: https://jenkins-tectonic-installer.prod.coreos.systems/job/tectonic-installer/job/master/82/console |
* tests/ci: add upstream-terraform-trigger as jenkins script * tests/ci: remove old job and remove block synchronously * tests/ci: revert the way to trigger the job
2 participants
this fixes #1559
waiting for #1444 to be merged then I can update this PR to remove some unnecessary files.
cc @mxinden @squat