This repository was archived by the owner on Feb 5, 2020. It is now read-only.
docs: add missing permission#105
Merged
sym3tri merged 1 commit intocoreos:masterfrom Dec 13, 2017
cpanato:INST-714
Merged
Conversation
Contributor
|
@cpanato LGTM |
Contributor
Author
|
This PR introduced the changes: coreos/tectonic-installer#2362 cc @sym3tri |
Contributor
|
@cpanato are you sure? I don't see |
Contributor
Author
|
@sym3tri sorry it came from here: coreos/bugs#2266 |
Contributor
|
@cpanato that's just the request to add it. Is there someplace recently that added that permission as a requirement? Maybe @s-urbaniak knows? |
|
Code blocks like this
https://github.com/coreos/tectonic-installer/blob/master/modules/aws/master-asg/master.tf#L92-L95
could be the source. But after looking at the TF code this invokes
iam:GetRole. Maybe the OP hits edge cases enumerated here:
https://www.terraform.io/docs/providers/aws/index.html#getting-the-account-id
.
…On Tue, Dec 12, 2017 at 4:13 PM, Ed Rooth ***@***.***> wrote:
@cpanato <https://github.com/cpanato> that's just the request to add it.
Is there someplace recently that added that permission as a requirement?
Maybe @s-urbaniak <https://github.com/s-urbaniak> knows?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#105 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAW8MEkHEvvbW3yut-9DkXq3IdeKFvsfks5s_pgagaJpZM4Q7PsT>
.
|
Contributor
|
Figured it out with Carlos. It was an addition to the GUI backend. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: coreos/bugs#2266 and INST-714