Add an arch package
#12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgwalters
force-pushed
the
arch-translation
branch
from
882e268 to
d17b12c
Compare
Many users of this package will want to translate between Go and RPM architectures. This moves code that exists in coreos-assembler (and can then be deleted from there): https://github.com/coreos/coreos-assembler/blob/master/mantle/system/arch.go
cgwalters
force-pushed
the
arch-translation
branch
from
d17b12c to
2896621
Compare
kelvinfan001
approved these changes
Jan 21, 2021
| return m.rpmArch | ||
| } | ||
| } | ||
| return goarch |
There was a problem hiding this comment.
Maybe this isn't a concern, but would the "pass through" assumption be potentially deceiving? e.g. one would assume whatever comes out of the RpmArch function is definitely an RPM Arch.
There was a problem hiding this comment.
It's definitely a concern! The downside is that we'd need to maintain an exhaustive list here of all architectures to validate it, I didn't think that was worth the maintenance overhead.
There was a problem hiding this comment.
A good example is I notice the coreos-assembler code is already missing RISC-V and...honestly I'm not sure if that matches or not. OK looks like the Go arch is riscv64 and the RPM one is (time passes while I dig in links from here) that too! Hooray.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many users of this package will want to translate between
Go and RPM architectures. This moves code that exists
in coreos-assembler (and can then be deleted from there):
https://github.com/coreos/coreos-assembler/blob/master/mantle/system/arch.go