Conversation
| '[ ! -d ${VMCHECK_INSTTREE} ] || exit 0 | ||
| DESTDIR=${VMCHECK_INSTTREE} | ||
| make install DESTDIR=${DESTDIR} | ||
| for san in a t ub; do |
There was a problem hiding this comment.
(And now if one wants to build with e.g. asan, install it into the insttree too)
cgwalters
force-pushed
the
live-updates-prep
branch
from
14cc0f1 to
596c9c7
Compare
| done | ||
| touch ${DESTDIR}/.completed' | ||
| [ -f insttree/.completed ] | ||
| [ -f ${VMCHECK_INSTTREE}/.completed ] |
There was a problem hiding this comment.
We should also update the rm -rf in Makefile-tests.am.
There was a problem hiding this comment.
I pushed a fixup to add the VMCHECK_INSTTREE stuff to this one, but i removed the rm -rf for now since handling the logic correctly would need to check if it was set or not...and anyways we want to nuke all of this logic later with livefs + rpm installs or so.
Makefile-daemon.am
Outdated
| --interface-prefix org.projectatomic.rpmostree1 \ | ||
| --c-namespace RPMOSTree \ | ||
| --c-generate-object-manager \ | ||
| --c-generate-autocleanup=all \ |
There was a problem hiding this comment.
Ahh no wonder I couldn't find this on my machine. This was added in Glib 2.50, but F24 is on 2.48. I will upgrade soon (or at least switch to containers), though F24 is still supported, right? I guess this depends on the outcome of https://pagure.io/atomic-wg/issue/228, though I'd like to be able to keep releasing to F24 if we're gonna keep running composes for it. Can we leave this off for now?
There was a problem hiding this comment.
Kind of sucks to be dragged back by Fedora 24 😦...one of the major goals of rpm-ostree being making host system upgrades more reliable. But OK for now.
There was a problem hiding this comment.
I dropped the change for now ⬇️ and will rework livefs to not need it.
I need to build ostree from git too. So now my workflow is:
```
export insttree=/srv/walters/tmp/rootfs
cd ostree
make && make install DESTDIR=${insttree}
cd rpm-ostree
make && make install DESTDIR=${insttree}
env VMCHECK_INSTTREE=${insttree} make vmoverlay
```
Also add a comment about enabling autoptr in the future.
Tempting to have a check that `git status` is clean after a build in CI.
cgwalters
force-pushed
the
live-updates-prep
branch
from
596c9c7 to
fa53c59
Compare
Also add a comment about enabling autoptr in the future. Closes: #705 Approved by: jlebon
Tempting to have a check that `git status` is clean after a build in CI. Closes: #705 Approved by: jlebon
|
☀️ Test successful - status-atomicjenkins |
3 participants
Build/test prep for #652