Conversation
tests/vmcheck/overlay.sh
Outdated
| for url in https://kojipkgs.fedoraproject.org//packages/ostree/2017.2/3.fc25/x86_64/ostree-{,libs-,grub2-}2017.2-3.fc25.x86_64.rpm; do | ||
| curl -sSL -O $url | ||
| done | ||
| ver=2017.3 |
There was a problem hiding this comment.
That also bumped the version from 2017.2 to 2017.3. Was that intentional?
Actually we should be able to dump this hack now. The fedora/25/atomic image has ostree-2017.2-3. (And it's nice, because I always have to cut ✂️ out that chunk on my computer because I use CAHC!).
There was a problem hiding this comment.
Yeah, though I need the newer version for livefs. Hmm. I'll do something else for that.
| rm vmcheck -rf | ||
| ostree checkout $commit vmcheck --fsync=0 | ||
| # https://github.com/projectatomic/rpm-ostree/pull/693 | ||
| rm -f vmcheck/usr/etc/{.pwd.lock,passwd-,group-,shadow-,gshadow-,subuid-,subgid-} |
There was a problem hiding this comment.
Can we make the comment there a bit more explicit re. the fact that this should be temporary? (Something like the nice ✂️ ✂️ ✂️ below).
| j.write(f.read()) | ||
| os.remove("vmcheck/%s.out" % self.test) | ||
| outfile = "vmcheck/{}.out".format(self.test) | ||
| if os.path.isfile(outfile): |
There was a problem hiding this comment.
Not a hack! I think that makes sense. If test.sh failed even before writing to the log file, opening will fail.
If test.sh failed even before writing to the log file, opening will fail.
Until we land <coreos#693> and it makes its way into all of our streams. Necessary for livefs.
The version in the current release has the fix.
cgwalters
force-pushed
the
vmcheck-fixes
branch
from
3682009 to
7cfadc5
Compare
|
Ok, reworked 🔧 |
The version in the current release has the fix. Closes: #698 Approved by: jlebon
|
☀️ Test successful - status-atomicjenkins |
3 participants
There's a hack in here, I don't quite understand the code.