packaging/rpm-ostree.spec: add libzstd-devel BuildRequires #5038
Conversation
packaging/rpm-ostree.spec
Outdated
| @@ -42,6 +42,7 @@ BuildRequires: rust | |||
| %bcond_without zchunk | |||
| %endif | |||
|
|
|||
| BuildRequires: libzstd-devel | |||
There was a problem hiding this comment.
Let's put it together with the other "Core requirements" BRs below? And add a comment that it's a dep of the ostree-ext crate.
There was a problem hiding this comment.
done, also added a commit message with what I understand changed on ostree-ext that now requires this. But I could be wrong.
After the initial changes to ostree-ext introducing support for zstd:chunked, which can be found in this pull request: ostreedev/ostree-rs-ext#615, an additional PR modified the dependency on zstd during build time to use pkg-config. You can review these changes in the pull request: ostreedev/ostree-rs-ext#628. These updates also required modifications to bootc, detailed in this pull request: containers/bootc#586. This commit mirrors those changes in rpm-ostree. With these changes, it will be possible to build RPMs on systems that do not have zstd-devel pre-installed in the build root.
|
@jmarrero: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
After the initial changes to ostree-ext introducing support for
zstd:chunked, which can be found in this pull request:
ostreedev/ostree-rs-ext#615,
an additional PR modified the dependency on zstd during build
time to use pkg-config.
You can review these changes in the pull request:
ostreedev/ostree-rs-ext#628.
These updates also required modifications to bootc, detailed in
this pull request: containers/bootc#586.
This commit mirrors those changes in rpm-ostree.
With these changes, it will be possible to build RPMs on systems
that do not have zstd-devel pre-installed in the build root.