Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rust/src/client: rpm-ostree cleanup -m on containers calls microdnf c… #3297

Merged
merged 1 commit into from
Jan 3, 2022
Merged

rust/src/client: rpm-ostree cleanup -m on containers calls microdnf c… #3297

merged 1 commit into from
Jan 3, 2022

Conversation

jmarrero
Copy link
Member

@jmarrero jmarrero commented Dec 22, 2021 •
edited
Loading

This Dockerfile:

FROM quay.io/cgwalters/fcos
ADD rpm-ostree /usr/bin/
RUN rpm-ostree --version
RUN rpm-ostree install htop && rpm-ostree cleanup -m

Ends up in:

STEP 1/4: FROM quay.io/cgwalters/fcos
STEP 2/4: ADD rpm-ostree /usr/bin/
--> f2fe68a8c39
STEP 3/4: RUN rpm-ostree --version
rpm-ostree:
 Version: '2021.14'
 Git: v2021.14-97-g023f86ade5559790fada0780b501e478244207f9
 Features:
  - rust
  - compose
  - fedora-integration
  - bin-unit-tests
--> 6b28e5e31aa
STEP 4/4: RUN rpm-ostree install htop && rpm-ostree cleanup -m
Downloading metadata...
Downloading metadata...
Downloading metadata...
Downloading metadata...
Downloading metadata...
Downloading metadata...
Package                   Repository            Size
Installing:                                         
 htop-3.1.2-1.fc35.x86_64 updates    176.4\xc2\xa0kB
Transaction Summary:
 Installing:        1 packages
 Reinstalling:      0 packages
 Upgrading:         0 packages
 Obsoleting:        0 packages
 Removing:          0 packages
 Downgrading:       0 packages
Downloading packages...
Running transaction test...
Installing: htop;3.1.2-1.fc35;x86_64;updates
Complete.
Complete.
COMMIT localhost/rpm-ostree
--> 45a8c0cd16f
Successfully tagged localhost/rpm-ostree:latest
45a8c0cd16f514108419ae0fc029b86fcd4aa00e60fe8e12e37fb65a2076f2f4

@openshift-ci
Copy link

openshift-ci bot commented Dec 22, 2021

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@jmarrero jmarrero marked this pull request as ready for review December 22, 2021 16:10
cgwalters
cgwalters reviewed Dec 22, 2021
View reviewed changes
Copy link
Member

@cgwalters cgwalters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, the CXX_TRY thing should be fixed, the new API is optional/followup.

cgwalters added a commit to cgwalters/ostree-rs-ext that referenced this pull request Dec 22, 2021
@cgwalters
lib/container_utils: Add helper is_ostree_contaner()
04c2b34 
This came up in coreos/rpm-ostree#3297

Most of our checks are going to be for this.
@cgwalters cgwalters mentioned this pull request Dec 22, 2021
Merged
@jmarrero jmarrero requested a review from cgwalters December 22, 2021 18:42
cgwalters
cgwalters approved these changes Jan 3, 2022
View reviewed changes
Copy link
Member

@cgwalters cgwalters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@cgwalters cgwalters merged commit a6bee3b into coreos:main Jan 3, 2022
@jmarrero jmarrero deleted the cleanup-m branch January 3, 2022 17:45
@jmarrero jmarrero restored the cleanup-m branch January 11, 2022 03:56
@jmarrero jmarrero mentioned this pull request Feb 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgwalters cgwalters cgwalters approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmarrero @cgwalters