build-sys: Rollup rework v1 #2526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Split this out of #2518 as I think it's the later linker cleanups which are provoking the GNU ld bug at least. |
cgwalters
force-pushed
the
libdnf-sys-build-cargo-smaller
branch
from
2eafe42 to
c673a13
Compare
Now that we are generating solely a Rust binary, we can have the canonical list of things to link on the Rust side.
cgwalters
force-pushed
the
libdnf-sys-build-cargo-smaller
branch
from
c673a13 to
f25cd09
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, lucab The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move libdnf build over to Cargo
This is now further migration towards Cargo/Rust possible
because we switched our main binary. We've had an internal
libdnf-syscrate for a while, but now it can take overthe build of the underlying library too (like many
-syscrates support).
This itself is just an incremental step towards migrating
the main rpm-ostree build system to e.g. cmake too (or
perhaps directly with the
cccrate, not sure yet) anddriving it via
cargotoo.build-sys: Move -lcap linkage purely to Rust
Now that we are generating solely a Rust binary, we can
have the canonical list of things to link on the Rust side.
build-sys: Move -lstdc++ -lrt into Cargo
More draining.
build-sys: Move -lm -ldl linkage into Cargo
More Rust, less shell/m4 - the world gets slightly better.
build-sys: Drop Fedora 25+ rpm version check
I think we can just assume this nowadays.