Skip to content

Conversation

@cgwalters
Copy link
Member

We want to test upgrades that actually change files as a general
rule; in some cases we want to test "large" upgrades to validate
performance.

This code generates a "synthetic" upgrade that adds an ELF note
to a percentage of ELF files (randomly selected). By doing
it this way we are only actually testing one version of the code.

Migrated from coreos/coreos-assembler#1635
using the Rust code from ostreedev/ostree#2127

@cgwalters
Copy link
Member Author

I only compile tested this locally because I forgot how to run the old vmcheck tests using fcos.

Copy link
Member

@jlebon jlebon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only compile tested this locally because I forgot how to run the old vmcheck tests using fcos.

Once you have a qcow2, you can just do ln -sf /path/to/my.qcow2 tests/vmcheck/image.qcow2 then run tests/vmcheck.sh.

We want to test upgrades that actually change files as a general
rule; in some cases we want to test "large" upgrades to validate
performance.

This code generates a "synthetic" upgrade that adds an ELF note
to a percentage of ELF files (randomly selected).  By doing
it this way we are only actually testing one version of the code.

Migrated from coreos/coreos-assembler#1635
using the Rust code from ostreedev/ostree#2127
@cgwalters
Copy link
Member Author

Once you have a qcow2, you can just do ln -sf /path/to/my.qcow2 tests/vmcheck/image.qcow2 then run tests/vmcheck.sh.

Yep I reread the .cci.jenkinsfile for that. We need to streamline/standardize this workflow with cosa build-fast etc.

@cgwalters
Copy link
Member Author

Got a passed run with env TESTS=upgrades ./tests/vmcheck.sh with this.

@jlebon
Copy link
Member

jlebon commented Aug 18, 2020

Very cool!
/lgtm

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, jlebon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cgwalters
Copy link
Member Author

One important thing I forgot to mention is that by doing this we can't use objcopy anymore, which gets into coreos/coreos-assembler#1645

@openshift-merge-robot openshift-merge-robot merged commit e3978c9 into coreos:master Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants