-
Notifications
You must be signed in to change notification settings - Fork 212
Add testutils generate-synthetic-upgrade #2199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I only compile tested this locally because I forgot how to run the old vmcheck tests using fcos. |
jlebon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only compile tested this locally because I forgot how to run the old vmcheck tests using fcos.
Once you have a qcow2, you can just do ln -sf /path/to/my.qcow2 tests/vmcheck/image.qcow2 then run tests/vmcheck.sh.
We want to test upgrades that actually change files as a general rule; in some cases we want to test "large" upgrades to validate performance. This code generates a "synthetic" upgrade that adds an ELF note to a percentage of ELF files (randomly selected). By doing it this way we are only actually testing one version of the code. Migrated from coreos/coreos-assembler#1635 using the Rust code from ostreedev/ostree#2127
f28bff0 to
c257bad
Compare
Yep I reread the |
|
Got a passed run with |
|
Very cool! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, jlebon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
One important thing I forgot to mention is that by doing this we can't use |
We want to test upgrades that actually change files as a general
rule; in some cases we want to test "large" upgrades to validate
performance.
This code generates a "synthetic" upgrade that adds an ELF note
to a percentage of ELF files (randomly selected). By doing
it this way we are only actually testing one version of the code.
Migrated from coreos/coreos-assembler#1635
using the Rust code from ostreedev/ostree#2127