compose: Allow specifying lockfile-repos only#2071
Merged
openshift-merge-robot merged 2 commits intocoreos:masterfrom Apr 29, 2020
Merged
compose: Allow specifying lockfile-repos only#2071openshift-merge-robot merged 2 commits intocoreos:masterfrom
openshift-merge-robot merged 2 commits intocoreos:masterfrom
Conversation
For Fedora CoreOS production streams, we want to *only* source from lockfile repos. But right now, rpm-ostree doesn't allow not specifying `repos`. Relax this restriction and just check that at least one of the two was provided.
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlebon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cgwalters
reviewed
Apr 28, 2020
| /* at least one of `repos` and `lockfile-repos` should be defined */ | ||
| if (!json_object_has_member (treedata, "repos") && | ||
| !json_object_has_member (treedata, "lockfile-repos")) | ||
| return glnx_null_throw (error, "Treefile has neither \"repos\" nor \"lockfile-repos\" members"); |
Member
Author
There was a problem hiding this comment.
This function actually returns a pointer, not a gboolean/int. I added a commit to convert all the return FALSE in here to return NULL.
Even though C happily accepts 0 for NULL, this is ambiguous with our coding style. E.g. here we're actually returning a pointer, not a gboolean. So let's be less misleading.
Member
|
/lgtm |
Member
Author
|
/refresh |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For Fedora CoreOS production streams, we want to only source from
lockfile repos. But right now, rpm-ostree doesn't allow not specifying
repos. Relax this restriction and just check that at least one of thetwo was provided.